Add trait methods for constructing alloy_rpc_types_eth::Transaction to alloy_consensus::Transaction
#1172
+379
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
This was referenced Aug 21, 2024
mattsse
requested changes
Aug 22, 2024
klkvr
reviewed
Aug 22, 2024
| /// | ||
| /// This is different than the `max_priority_fee_per_gas` method, which returns `None` for | ||
| /// non-EIP-1559 transactions. | ||
| fn priority_fee_or_price(&self) -> u128; |
There was a problem hiding this comment.
I think this can have a default impl like self.max_priority_fee_per_gas().unwrap_or(self.max_fee_per_gas())
though I'm wondering what's a usecase for this method?
There was a problem hiding this comment.
ah got it, its basically how execution layer treats legacy txses wrt priority fee
Co-authored-by: Arsenii Kulikov <[email protected]>
mattsse
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Removing the optimism feature from
reth-rpc-types-compatin a simple way, requires implementing the conversion from a signed transaction into an rpc transaction object, into the crates that define the associated types ofalloy_network::Network. Otherwise, we are not able to access the additional OP fields for example.Moving into
reth-optimsim-rpcis not an option, since neither the trait for conversion nor the<op_alloy_network::Optimism as Network>::TransactionResponsetype are defined in thereth-optimsim-rpccrateSolution
Adds trait methods to
alloy_consensus::Transaction, and implements for respective types following implementation of https://github.com/paradigmxyz/reth/blob/302ce7f482d5c3189457fe43d8155676d01766ff/crates/transaction-pool/src/traits.rs#L766-L876PR Checklist